Fix formatting of code longer than Discord's message limit#549
Merged
danthe1st merged 12 commits intoJun 25, 2026
Conversation
danthe1st
requested changes
Jun 20, 2026
danthe1st
left a comment
danthe1st
left a comment
Member
There was a problem hiding this comment.
Congratulations on writing your first pull request. I commented on a few things I noticed. Please don't unnecessarily duplicate code.
Member
|
Fixes #537 |
…nto fix/format-code-long-messages # Conflicts: # src/main/java/net/discordjug/javabot/systems/user_commands/format_code/Code.java # src/main/java/net/discordjug/javabot/systems/user_commands/format_code/FormatCodeDispatcher.java # src/main/java/net/discordjug/javabot/systems/user_commands/format_code/Language.java
danthe1st
requested changes
Jun 23, 2026
danthe1st
left a comment
danthe1st
left a comment
Member
There was a problem hiding this comment.
These are mostly minor comments. Is there any good reason why users would want a file response in addition to the codeblocks?
danthe1st
requested changes
Jun 24, 2026
Member
There was a problem hiding this comment.
Overall, your PR looks pretty good.
During testing, I noticed that it's possible to send a single message that can result in a lot of individual (and big). As an example, you can generate the content of such a message with the following code:
System.out.println("{".repeat(30)+"\n"+"a\n".repeat(1000)+"}".repeat(30));Please add a limit to this. I don't want to have to clean that up without knowing the exact number (I think it is possible to trigger more than 500 messages with a single message that way). See the second review comment here for how to fix it.
danthe1st
reviewed
Jun 24, 2026
danthe1st
requested changes
Jun 24, 2026
danthe1st
requested changes
Jun 25, 2026
danthe1st
left a comment
danthe1st
left a comment
Member
There was a problem hiding this comment.
There's one small typo remaining, otherwise it looks good.
…nto fix/format-code-long-messages # Conflicts: # src/main/java/net/discordjug/javabot/systems/user_commands/format_code/FormatCodeDispatcher.java
danthe1st
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
The "Format Code" / "Format and Indent Code" message commands and the
/format-codeslash command failed when the target message was longer than Discord's 2000-character limit: the whole snippet was wrapped in a single code block and sent as one message, which Discord rejects — so the command silently did nothing.This PR splits the formatted output into chunks that each stay under the limit:
Codeclass splits content into ≤1980-character chunks (breaking on newlines where possible) and renders each as a code block.Languageenum +Language.fromString(...)maps the slash command'sformatoption to a code-fence tag.A follow-up PR will add the language-selection dropdown.